• Sara Sharon's avatar
    iwlwifi: pcie: fix TX while flushing · 2ae48edc
    Sara Sharon authored
    When flushing TX queues no new TX should go into the system.
    However, in the following scenario we get TX:
    1. Queues are stopped and there are packets in overflow queue
    2. Station is removed and flush begins
    3. Flush empties space, and reclaim path TXes SKB from overflow
       queue.
    
    Note that the fact the queues are stopped during the process
    doesn't matter - the packet will be TXed since the TX path
    doesn't care if TX queues are stopped or not, just if there is
    space in the queue, which there is, since we just freed a
    packet.
    
    A fix here is rather complicated, since the flow is very racy.
    
    Change code not to warn if we are TXing from overflow TX.
    In case there is TX from both overflow TX and TX path we will
    miss a warning we optimally had, but we can live with that.
    
    Make sure we don't return before overflow queue is empty, otherwise
    we will think queues are empty, but they will be refilled, resulting
    with assert.
    Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
    Fixes: 3955525d ("iwlwifi: pcie: buffer packets to avoid overflowing Tx queues")
    Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
    2ae48edc
tx.c 70.8 KB