• Tomi Valkeinen's avatar
    OMAPDSS: DISPC: get dss clock rate from dss driver · 5aaee69d
    Tomi Valkeinen authored
    Dispc currently gets dispc's fck with clk_get() and uses clk_get_rate()
    to get the rate for scaling calculations. This causes a problem with
    common clock framework, as omapdss uses the dispc functions inside a
    spinlock, and common clock framework uses a mutex in clk_get_rate().
    
    Looking at the DSS clock tree, the above use of the dispc fck is not
    quite correct. The DSS_FCLK from PRCM goes to DSS core block, which has
    a mux to select the clock for DISPC from various options, so the current
    use of dispc fck bypasses that. Fortunately we never change the dispc
    clock mux for now.
    
    To fix the issue with clk_get_rate(), this patch caches the dss clock
    rate in dss.c when it is set. Dispc will then ask for the clock rate
    from dss. While this is not very elegant, it does fix the issue, and
    it's not totally wrong when considering that the dispc fck actually
    comes via dss.
    
    In the future we should probably look into common clock framework and
    see if that could be used to represent the DSS clock tree properly.
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    5aaee69d
dss.c 22.6 KB