• Baolin Wang's avatar
    blk-cgroup: Use cond_resched() when destroy blkgs · 6c635cae
    Baolin Wang authored
    On !PREEMPT kernel, we can get below softlockup when doing stress
    testing with creating and destroying block cgroup repeatly. The
    reason is it may take a long time to acquire the queue's lock in
    the loop of blkcg_destroy_blkgs(), or the system can accumulate a
    huge number of blkgs in pathological cases. We can add a need_resched()
    check on each loop and release locks and do cond_resched() if true
    to avoid this issue, since the blkcg_destroy_blkgs() is not called
    from atomic contexts.
    
    [ 4757.010308] watchdog: BUG: soft lockup - CPU#11 stuck for 94s!
    [ 4757.010698] Call trace:
    [ 4757.010700]  blkcg_destroy_blkgs+0x68/0x150
    [ 4757.010701]  cgwb_release_workfn+0x104/0x158
    [ 4757.010702]  process_one_work+0x1bc/0x3f0
    [ 4757.010704]  worker_thread+0x164/0x468
    [ 4757.010705]  kthread+0x108/0x138
    Suggested-by: default avatarTejun Heo <tj@kernel.org>
    Signed-off-by: default avatarBaolin Wang <baolin.wang@linux.alibaba.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    6c635cae
blk-cgroup.c 50.2 KB