• Tomi Valkeinen's avatar
    HACK: drm/omap: always use blocking DMM fill · 2bb2daf3
    Tomi Valkeinen authored
    The current driver uses non-blocking DMM fill when releasing memory.
    This gives us a small performance increase as we don't have to wait for
    the fill operation to finish.
    
    However, the driver does not have any error handling for non-blocking
    fill. In case of an error, the fill operation may silently fail, leading
    to leaking DMM engines, which may eventually lead to deadlock if we run
    out of DMM engines.
    
    This patch makes the DMM driver always use blocking fills, so that we
    can catch the errors. A more complex option would be to allow
    non-blocking fills, and implement proper error handling, but that is
    left for the future.
    
    This patch is a HACK, as the proper fix is to either decide to always
    use sync fills and remove all the async related code, or fix the async
    code.
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    2bb2daf3
omap_dmm_tiler.c 26 KB