• Qu Wenruo's avatar
    btrfs: cleanup for extent_write_locked_range() · 2bd0fc93
    Qu Wenruo authored
    There are several cleanups for extent_write_locked_range(), most of them
    are pure cleanups, but with some preparation for future subpage support.
    
    - Add a proper comment for which call sites are suitable
      Unlike regular synchronized extent write back, if async COW or zoned
      COW happens, we have all pages in the range still locked.
    
      Thus for those (only) two call sites, we need this function to submit
      page content into bios and submit them.
    
    - Remove @mode parameter
      All the existing two call sites pass WB_SYNC_ALL. No need for @mode
      parameter.
    
    - Better error handling
      Currently if we hit an error during the page iteration loop, we
      overwrite @ret, causing only the last error can be recorded.
    
      Here we add @found_error and @first_error variable to record if we hit
      any error, and the first error we hit.
      So the first error won't get lost.
    
    - Don't reuse @start as the cursor
      We reuse the parameter @start as the cursor to iterate the range, not
      a big problem, but since we're here, introduce a proper @cur as the
      cursor.
    
    - Remove impossible branch
      Since all pages are still locked after the ordered extent is inserted,
      there is no way that pages can get its dirty bit cleared.
      Remove the branch where page is not dirty and replace it with an
      ASSERT().
    Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    2bd0fc93
inode.c 307 KB