• Chen Gang's avatar
    qla2xxx: remove redundant declaration in 'qla_gbl.h' · 2bf2d29e
    Chen Gang authored
    commit 9493c242 upstream.
    
    Remove 2 redundant extern inline functions: qla8044_set_qsnt_ready() and
    qla8044_need_reset_handler(). At present, within upstream next kernel
    source code, they are only used within "drivers/scsi/qla2xxx/qla_nx2.c".
    
    The related error and warnings (with allmodconfig under tile):
    
        CC [M]  drivers/scsi/qla2xxx/qla_nx2.o
      drivers/scsi/qla2xxx/qla_nx2.c:1633:1: error: static declaration of 'qla8044_need_reset_handler' follows non-static declaration
       qla8044_need_reset_handler(struct scsi_qla_host *vha)
       ^
      In file included from drivers/scsi/qla2xxx/qla_def.h:3706:0,
                       from drivers/scsi/qla2xxx/qla_nx2.c:11:
      drivers/scsi/qla2xxx/qla_gbl.h:756:20: note: previous declaration of 'qla8044_need_reset_handler' was here
       extern inline void qla8044_need_reset_handler(struct scsi_qla_host *vha);
                          ^
      drivers/scsi/qla2xxx/qla_gbl.h:756:20: warning: inline function 'qla8044_need_reset_handler' declared but never defined
      make[3]: *** [drivers/scsi/qla2xxx/qla_nx2.o] Error 1
      make[2]: *** [drivers/scsi/qla2xxx] Error 2
      make[1]: *** [drivers/scsi] Error 2
      make: *** [drivers] Error 2
    
        CC [M]  drivers/scsi/qla2xxx/qla_tmpl.o
      In file included from drivers/scsi/qla2xxx/qla_def.h:3706:0,
                       from drivers/scsi/qla2xxx/qla_tmpl.c:7:
      drivers/scsi/qla2xxx/qla_gbl.h:755:20: warning: inline function 'qla8044_set_qsnt_ready' declared but never defined
       extern inline void qla8044_set_qsnt_ready(struct scsi_qla_host *vha);
                        ^
    Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
    Acked-by: default avatarSaurav Kashyap <saurav.kashyap@qlogic.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Cc: Philip Müller <philm@manjaro.org>
    Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
    2bf2d29e
qla_gbl.h 30.1 KB