• Jeff LaBundy's avatar
    pwm: iqs620a: Correct a stale state variable · 28208c7b
    Jeff LaBundy authored
    If duty cycle is first set to a value that is sufficiently high to
    enable the output (e.g. 10000 ns) but then lowered to a value that
    is quantized to zero (e.g. 1000 ns), the output is disabled as the
    device cannot drive a constant zero (as expected).
    
    However if the device is later re-initialized due to watchdog bite,
    the output is re-enabled at the next-to-last duty cycle (10000 ns).
    This is because the iqs620_pwm->out_en flag unconditionally tracks
    state->enabled instead of what was actually written to the device.
    
    To solve this problem, use one state variable that encodes all 257
    states of the output (duty_scale) with 0 representing tri-state, 1
    representing the minimum available duty cycle and 256 representing
    100% duty cycle.
    Signed-off-by: default avatarJeff LaBundy <jeff@labundy.com>
    Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
    28208c7b
pwm-iqs620a.c 6.73 KB