• Ian Rogers's avatar
    perf report: Avoid 'parent_thread' thread leak on '--tasks' processing · 2c9f7bd7
    Ian Rogers authored
    Caught with address sanitizer and reference count checking.
    
    Committer notes:
    
    The command leading to this leak:
    
      # perf record -a sleep 2
      [ perf record: Woken up 1 times to write data ]
      [ perf record: Captured and wrote 2.516 MB perf.data (6422 samples) ]
      # perf report --tasks
      #      pid      tid     ppid  comm
               0        0       -1 |swapper
               1        1        0 | systemd
            1474     1474        1 |  systemd
            2816     2816     1474 |   gjs
            2816     2825     2816 |    gmain
            2816     2831     2816 |    gdbus
            2816     2861     2816 |    JS Helper
            2816     2862     2816 |    JS Helper
            2816     2863     2816 |    JS Helper
            2816     2864     2816 |    JS Helper
            2816     2865     2816 |    JS Helper
            2816     2866     2816 |    JS Helper
            2816     2867     2816 |    JS Helper
            2816     2868     2816 |    JS Helper
            3072     3072     1474 |   gsd-printer
            3072     3082     3072 |    gmain
            3072     3083     3072 |    gdbus
            2600     2600     1474 |   gnome-shell
           15621    15621     2600 |    firefox
           15771    15771    15621 |     WebExtensions
           15771    15872    15771 |      TaskCon~ller #6
           15771    15873    15771 |      TaskCon~ller #7
           15771    15778    15771 |      IPC I/O Child
           15771    15779    15771 |      Socket Thread
           15771    15780    15771 |      HTML5 Parser
           15771    15781    15771 |      JS Watchdog
      # <SNIP>
    
    When it is going to exit a thread__put(parent_thread) was missed, add it
    to have ASAN clean.
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ali Saidi <alisaidi@amazon.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Brian Robbins <brianrob@linux.microsoft.com>
    Cc: Changbin Du <changbin.du@huawei.com>
    Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
    Cc: Fangrui Song <maskray@google.com>
    Cc: German Gomez <german.gomez@arm.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Ivan Babrou <ivan@cloudflare.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: John Garry <john.g.garry@oracle.com>
    Cc: K Prateek Nayak <kprateek.nayak@amd.com>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Liam Howlett <liam.howlett@oracle.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Miguel Ojeda <ojeda@kernel.org>
    Cc: Mike Leach <mike.leach@linaro.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Sean Christopherson <seanjc@google.com>
    Cc: Steinar H. Gunderson <sesse@google.com>
    Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
    Cc: Wenyu Liu <liuwenyu7@huawei.com>
    Cc: Will Deacon <will@kernel.org>
    Cc: Yang Jihong <yangjihong1@huawei.com>
    Cc: Ye Xingchen <ye.xingchen@zte.com.cn>
    Cc: Yuan Can <yuancan@huawei.com>
    Cc: coresight@lists.linaro.org
    Cc: linux-arm-kernel@lists.infradead.org
    Link: https://lore.kernel.org/r/20230608232823.4027869-10-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    2c9f7bd7
builtin-report.c 48.6 KB