• Jacob Keller's avatar
    devlink: refactor region_read_snapshot_fill to use a callback function · 2d4caf09
    Jacob Keller authored
    The devlink_nl_region_read_snapshot_fill is used to copy the contents of
    a snapshot into a message for reporting to userspace via the
    DEVLINK_CMG_REGION_READ netlink message.
    
    A future change is going to add support for directly reading from
    a region. Almost all of the logic for this new capability is identical.
    
    To help reduce code duplication and make this logic more generic,
    refactor the function to take a cb and cb_priv pointer for doing the
    actual copy.
    
    Add a devlink_region_snapshot_fill implementation that will simply copy
    the relevant chunk of the region. This does require allocating some
    storage for the chunk as opposed to simply passing the correct address
    forward to the devlink_nl_cmg_region_read_chunk_fill function.
    
    A future change to implement support for directly reading from a region
    without a snapshot will provide a separate implementation that calls the
    newly added devlink region operation.
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
    Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    2d4caf09
devlink.c 334 KB