• David Howells's avatar
    afs: Fix dirty-region encoding on ppc32 with 64K pages · 2d9900f2
    David Howells authored
    The dirty region bounds stored in page->private on an afs page are 15 bits
    on a 32-bit box and can, at most, represent a range of up to 32K within a
    32K page with a resolution of 1 byte.  This is a problem for powerpc32 with
    64K pages enabled.
    
    Further, transparent huge pages may get up to 2M, which will be a problem
    for the afs filesystem on all 32-bit arches in the future.
    
    Fix this by decreasing the resolution.  For the moment, a 64K page will
    have a resolution determined from PAGE_SIZE.  In the future, the page will
    need to be passed in to the helper functions so that the page size can be
    assessed and the resolution determined dynamically.
    
    Note that this might not be the ideal way to handle this, since it may
    allow some leakage of undirtied zero bytes to the server's copy in the case
    of a 3rd-party conflict.  Fixing that would require a separately allocated
    record and is a more complicated fix.
    
    Fixes: 4343d008 ("afs: Get rid of the afs_writeback record")
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Reviewed-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
    2d9900f2
write.c 22.2 KB