• Roland Dreier's avatar
    mlx4_core: Use mmiowb() to avoid firmware commands getting jumbled up · 2e61c646
    Roland Dreier authored
    Firmware commands are sent to the HCA by writing multiple words to a
    command register block.  Access to this block of registers is
    serialized with a mutex.  However, on large SGI systems writes to the
    register block may be reordered within the system interconnect and
    reach the HCA in a different order than they were issued (even with
    the mutex).  Fix this by adding an mmiowb() before dropping the mutex.
    
    This bug was observed with real workloads with the similar FW command
    code in the mthca driver, and adding the mmiowb() as in commit
    66547550 ("IB/mthca: Use mmiowb() to avoid firmware commands getting
    jumbled up") was confirmed to fix the problems, so we should add the
    same fix to mlx4.
    Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
    2e61c646
cmd.c 11.6 KB