• Uwe Kleine-König's avatar
    net: move jazzsonic's probe function to .devinit.text · 2e76baea
    Uwe Kleine-König authored
    A pointer to jazz_sonic_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.
    
    As noticed by Geert Uytterhoeven sonic_probe1 is called by
    jazz_sonic_probe, so the former has to move to .devinit.text, too.
    
    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.
    Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Acked-by: default avatarRalf Baechle <ralf@linux-mips.org>
    Cc: Jeff Garzik <jeff@garzik.org>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Cc: Finn Thain <fthain@telegraphics.com.au>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: netdev@vger.kernel.org
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2e76baea
jazzsonic.c 7.51 KB