• Xin Long's avatar
    sctp: remove sched init from sctp_stream_init · 2e990dfd
    Xin Long authored
    syzbot reported a NULL-ptr deref caused by that sched->init() in
    sctp_stream_init() set stream->rr_next = NULL.
    
      kasan: GPF could be caused by NULL-ptr deref or user memory access
      RIP: 0010:sctp_sched_rr_dequeue+0xd3/0x170 net/sctp/stream_sched_rr.c:141
      Call Trace:
        sctp_outq_dequeue_data net/sctp/outqueue.c:90 [inline]
        sctp_outq_flush_data net/sctp/outqueue.c:1079 [inline]
        sctp_outq_flush+0xba2/0x2790 net/sctp/outqueue.c:1205
    
    All sched info is saved in sout->ext now, in sctp_stream_init()
    sctp_stream_alloc_out() will not change it, there's no need to
    call sched->init() again, since sctp_outq_init() has already
    done it.
    
    Fixes: 5bbbbe32 ("sctp: introduce stream scheduler foundations")
    Reported-by: syzbot+4c9934f20522c0efd657@syzkaller.appspotmail.com
    Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
    Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
    Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2e990dfd
stream.c 28.5 KB