• Julia Lawall's avatar
    ASoC: rockchip: constify snd_soc_ops structures · 705e9994
    Julia Lawall authored
    Check for snd_soc_ops structures that are only stored in the ops field of a
    snd_soc_dai_link structure.  This field is declared const, so snd_soc_ops
    structures that have this property can be declared as const also.
    
    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct snd_soc_ops i@p = { ... };
    
    @ok1@
    identifier r.i;
    struct snd_soc_dai_link e;
    position p;
    @@
    e.ops = &i@p;
    
    @ok2@
    identifier r.i, e;
    position p;
    @@
    struct snd_soc_dai_link e[] = { ..., { .ops = &i@p, }, ..., };
    
    @bad@
    position p != {r.p,ok1.p,ok2.p};
    identifier r.i;
    struct snd_soc_ops e;
    @@
    e@i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
     struct snd_soc_ops i = { ... };
    // </smpl>
    
    The effect on the layout of the .o files is shown by the following output
    of the size command, first before then after the transformation:
    
       text    data     bss     dec     hex filename
       5027    2488     416    7931    1efb sound/soc/rockchip/rk3399_gru_sound.o
       5219    2312     416    7947    1f0b sound/soc/rockchip/rk3399_gru_sound.o
    
       text    data     bss     dec     hex filename
       3499    1648     384    5531    159b sound/soc/rockchip/rockchip_max98090.o
       3563    1584     384    5531    159b sound/soc/rockchip/rockchip_max98090.o
    
       text    data     bss     dec     hex filename
       3455    1536     384    5375    14ff sound/soc/rockchip/rockchip_rt5645.o
       3519    1480     384    5383    1507 sound/soc/rockchip/rockchip_rt5645.o
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    705e9994
rk3399_gru_sound.c 10.6 KB