• Sandipan Das's avatar
    perf script: Skip aggregation for stat events · 2fe65759
    Sandipan Das authored
    The script command does not support aggregation modes by itself although
    that can be achieved using post-processing scripts. Because of this, it
    does not allocate memory for aggregated event values.
    
    Upon running perf stat record, the aggregation mode is set in the perf
    data file. If the mode is AGGR_GLOBAL, the aggregated event values are
    accessed and this leads to a segmentation fault since these were never
    allocated to begin with. Set the mode to AGGR_NONE explicitly to avoid
    this.
    
    E.g.
    
      $ perf stat record -e cycles true
      $ perf script
    
    Before:
      Segmentation fault (core dumped)
    
    After:
      CPU   THREAD             VAL             ENA             RUN            TIME EVENT
       -1   231919          162831          362069          362069          935289 cycles:u
    
    Fixes: 8b76a318 ("perf stat: Remove unused perf_counts.aggr field")
    Signed-off-by: default avatarSandipan Das <sandipan.das@amd.com>
    Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ananth Narayan <ananth.narayan@amd.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Nick Terrell <terrelln@fb.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: stable@vger.kernel.org # v6.2+
    Link: https://lore.kernel.org/r/83d6c6c05c54bf00c5a9df32ac160718efca0c7a.1683280603.git.sandipan.das@amd.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    2fe65759
builtin-script.c 115 KB