• Arnaldo Carvalho de Melo's avatar
    perf trace: Preallocate the syscall table · 30a910d7
    Arnaldo Carvalho de Melo authored
    We'll continue reading its details from tracefs as we need it, but
    preallocate the whole thing otherwise we may realloc and end up with
    pointers to the previous buffer.
    
    I.e. in an upcoming algorithm we'll look for syscalls that have function
    signatures that are similar to a given syscall to see if we can reuse
    its BPF augmenter, so we may be at syscall 42, having a 'struct syscall'
    pointing to that slot in trace->syscalls.table[] and try to read the
    slot for an yet unread syscall, which would realloc that table to read
    the info for syscall 43, say, which would trigger a realoc of
    trace->syscalls.table[], and then the pointer we had for syscall 42
    would be pointing to the previous block of memory. b00m.
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: https://lkml.kernel.org/n/tip-m3cjzzifibs13imafhkk77a0@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    30a910d7
builtin-trace.c 121 KB