• John Hubbard's avatar
    mei: fix use-after-free in mei_cl_write · c1a214ad
    John Hubbard authored
    KASAN reports a use-after-free during startup, in mei_cl_write:
    
        BUG: KASAN: use-after-free in mei_cl_write+0x601/0x870 [mei]
           (drivers/misc/mei/client.c:1770)
    
    This is caused by commit 98e70866 ("mei: add support for variable
    length mei headers."), which changed the return value from len, to
    buf->size. That ends up using a stale buf pointer, because blocking
    call, the cb (callback) is deleted in me_cl_complete() function.
    
    However, fortunately, len remains unchanged throughout the function
    (and I don't see anything else that would require re-reading buf->size
    either), so the fix is to simply revert the change, and return len, as
    before.
    
    Fixes: 98e70866 ("mei: add support for variable length mei headers.")
    CC: Arnd Bergmann <arnd@arndb.de>
    CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
    Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c1a214ad
client.c 38.2 KB