• Dmitry V. Levin's avatar
    sparc: fix compat siginfo ABI regression · 32772c9e
    Dmitry V. Levin authored
    Starting with commit v4.14-rc1~60^2^2~1, a SIGFPE signal sent via kill
    results to wrong values in si_pid and si_uid fields of compat siginfo_t.
    
    This happens due to FPE_FIXME being defined to 0 for sparc, and at the
    same time siginfo_layout() introduced by the same commit returns
    SIL_FAULT for SIGFPE if si_code == SI_USER and FPE_FIXME is defined to 0.
    
    Fix this regression by removing FPE_FIXME macro and changing all its users
    to assign FPE_FLTUNK to si_code instead of FPE_FIXME.
    
    Note that FPE_FLTUNK is a new macro introduced by commit
    266da65e.
    
    Tested with commit v4.16-11958-g16e205cf.
    
    This bug was found by strace test suite.
    
    In the discussion about FPE_FLTUNK on sparc David Miller said:
    > Eric, feel free to do something similar on Sparc.
    
    Link: https://github.com/strace/strace/issues/21
    Fixes: cc731525 ("signal: Remove kernel interal si_code magic")
    Fixes: 2.3.41
    Cc: David Miller <davem@davemloft.net>
    Cc: sparclinux@vger.kernel.org
    Conceptually-Acked-By: default avatarDavid Miller <davem@davemloft.net>
    Thanks-to: Anatoly Pugachev <matorola@gmail.com>
    Signed-off-by: default avatarDmitry V. Levin <ldv@altlinux.org>
    Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
    32772c9e
traps_64.c 85.5 KB