• Arnd Bergmann's avatar
    clk: ti: divider: try to fix ti_clk_register_divider · 3417f352
    Arnd Bergmann authored
    Commit 6c0afb50 ("clk: ti: convert to use proper register
    definition for all accesses") converted all register accesses in
    the TI clk driver to use a proper struct instead of a void
    pointer casted struct that fits into a u32. Unfortunately, it
    missed a conversion here in the didivder code, leading to a
    compiler warning like so:
    
    drivers/clk/ti/divider.c: In function 'ti_clk_register_divider':
    drivers/clk/ti/divider.c:460:8: error: 'reg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    Treating a 'u32' variable as a structure leads to a stack
    overflow here, and the register address we pass down is never
    initialized. Convert this part of the code as well so things
    work properly.
    
    Fixes: 6c0afb50 ("clk: ti: convert to use proper register definition for all accesses")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    [sboyd@codeaurora.org: Fixed fixes tag, rewrote commit message,
    s/reg_setup/reg/]
    Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    3417f352
divider.c 14.4 KB