• Athira Rajeev's avatar
    perf test bpf: Skip test if kernel-debuginfo is not present · 34266f90
    Athira Rajeev authored
    Perf BPF filter test fails in environment where "kernel-debuginfo"
    is not installed.
    
    Test failure logs:
    
      <<>>
      42: BPF filter                            :
      42.1: Basic BPF filtering                 : Ok
      42.2: BPF pinning                         : Ok
      42.3: BPF prologue generation             : FAILED!
      <<>>
    
    Enabling verbose option provided debug logs, which says debuginfo
    needs to be installed. Snippet of verbose logs:
    
      <<>>
      42.3: BPF prologue generation                                       :
      --- start ---
      test child forked, pid 28218
      <<>>
      Rebuild with CONFIG_DEBUG_INFO=y, or install an appropriate debuginfo
      package.
      bpf_probe: failed to convert perf probe events
      Failed to add events selected by BPF
      test child finished with -1
      ---- end ----
      BPF filter subtest 3: FAILED!
      <<>>
    
    Here the subtest "BPF prologue generation" failed and logs shows
    debuginfo is needed. After installing kernel-debuginfo package, testcase
    passes.
    
    The "BPF prologue generation" subtest failed because, the do_test()
    returns TEST_FAIL without checking the error type returned by
    parse_events_load_bpf_obj().
    
    parse_events_load_bpf_obj() can also return error of type -ENODATA
    incase kernel-debuginfo package is not installed. Fix this by adding
    check for -ENODATA error.
    
    Test result after the patch changes:
    
    Test failure logs:
    
      <<>>
      42: BPF filter                 :
      42.1: Basic BPF filtering      : Ok
      42.2: BPF pinning              : Ok
      42.3: BPF prologue generation  : Skip (clang/debuginfo isn't installed or environment missing BPF support)
      <<>>
    
    Fixes: ba1fae43 ("perf test: Add 'perf test BPF'")
    Signed-off-by: default avatarAthira Rajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Disha Goel <disgoel@linux.ibm.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kajol Jain <kjain@linux.ibm.com>
    Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Nageswara R Sastry <rnsastry@linux.ibm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Cc: linuxppc-dev@lists.ozlabs.org
    Link: http://lore.kernel.org/linux-perf-users/Y7bIk77mdE4j8Jyi@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    34266f90
bpf.c 9.29 KB