• Pavel Begunkov's avatar
    io_uring: unpark SQPOLL thread for cancelation · 34343786
    Pavel Begunkov authored
    We park SQPOLL task before going into io_uring_cancel_files(), so the
    task won't run task_works including those that might be important for
    the cancellation passes. In this case it's io_poll_remove_one(), which
    frees requests via io_put_req_deferred().
    
    Unpark it for while waiting, it's ok as we disable submissions
    beforehand, so no new requests will be generated.
    
    INFO: task syz-executor893:8493 blocked for more than 143 seconds.
    Call Trace:
     context_switch kernel/sched/core.c:4327 [inline]
     __schedule+0x90c/0x21a0 kernel/sched/core.c:5078
     schedule+0xcf/0x270 kernel/sched/core.c:5157
     io_uring_cancel_files fs/io_uring.c:8912 [inline]
     io_uring_cancel_task_requests+0xe70/0x11a0 fs/io_uring.c:8979
     __io_uring_files_cancel+0x110/0x1b0 fs/io_uring.c:9067
     io_uring_files_cancel include/linux/io_uring.h:51 [inline]
     do_exit+0x2fe/0x2ae0 kernel/exit.c:780
     do_group_exit+0x125/0x310 kernel/exit.c:922
     __do_sys_exit_group kernel/exit.c:933 [inline]
     __se_sys_exit_group kernel/exit.c:931 [inline]
     __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:931
     do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
     entry_SYSCALL_64_after_hwframe+0x44/0xa9
    
    Cc: stable@vger.kernel.org # 5.5+
    Reported-by: syzbot+695b03d82fa8e4901b06@syzkaller.appspotmail.com
    Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    34343786
io_uring.c 249 KB