• Oleg Nesterov's avatar
    signals: handle_stop_signal: don't worry about SIGKILL · 34c8f07b
    Oleg Nesterov authored
    handle_stop_signal() clears SIGNAL_STOP_DEQUEUED when sig == SIGKILL.  Remove
    this nasty special case.  It was needed to prevent the race with group stop
    and exit caused by thread-specific SIGKILL.  Now that we use complete_signal()
    for private signals too this is not needed, complete_signal() will notice
    SIGKILL and abort the soon-to-begin group stop.
    
    Except: the target thread is dead (has PF_EXITING).  But in that case we
    should not just clear SIGNAL_STOP_DEQUEUED and nothing more.  We should either
    kill the whole thread group, or silently ignore the signal.
    
    I suspect we are not right wrt zombie leaders, but this is another issue which
    and should be fixed separately.  Note that this check can't abort the group
    stop if it was already started/finished, this check only adds a subtle side
    effect if we race with the thread which has already dequeued sig_kernel_stop()
    signal and temporary released ->siglock.
    Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
    Cc: Roland McGrath <roland@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    34c8f07b
signal.c 62.6 KB