• Krzysztof Kozlowski's avatar
    nfc: hci: pass callback data param as pointer in nci_request() · 35d7a6f1
    Krzysztof Kozlowski authored
    The nci_request() receives a callback function and unsigned long data
    argument "opt" which is passed to the callback.  Almost all of the
    nci_request() callers pass pointer to a stack variable as data argument.
    Only few pass scalar value (e.g. u8).
    
    All such callbacks do not modify passed data argument and in previous
    commit they were made as const.  However passing pointers via unsigned
    long removes the const annotation.  The callback could simply cast
    unsigned long to a pointer to writeable memory.
    
    Use "const void *" as type of this "opt" argument to solve this and
    prevent modifying the pointed contents.  This is also consistent with
    generic pattern of passing data arguments - via "void *".  In few places
    which pass scalar values, use casts via "unsigned long" to suppress any
    warnings.
    Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    35d7a6f1
nci_core.h 12.9 KB