• Paul Walmsley's avatar
    OMAP clockdomains: add usecounting for wakeup and sleep dependencies · 369d5614
    Paul Walmsley authored
    Add usecounting for wakeup and sleep dependencies.  In the current
    situation, if several functions add dependencies on the same
    clockdomains, when the first dependency removal function is called,
    the dependency will be incorrectly removed from the hardware.
    
    Add clkdm_clear_all_wkdeps() and clkdm_clear_all_sleepdeps(), which
    provide a fast and usecounting-consistent way to clear all hardware
    clockdomain dependencies, since accesses to these registers can be
    quite slow.  pm{2,3}4xx.c has been updated to use these new functions.
    The original version of this patch did not touch these files, which
    previously wrote directly to the wkdep registers, and thus confused
    the usecounting code.  This problem was found by Kevin Hilman
    <khilman@deeprootsystems.com>.
    
    N.B.: This patch introduces one significant functional difference over
    the previous pm34xx.c code: sleepdeps are now cleared during
    clockdomain initialization, whereas previously they were left
    untouched.  This has been tested by Kevin and confirmed to work.
    
    The original version of this patch also did not take into
    consideration that some clockdomains do not have sleep or wakeup
    dependency sources, which caused NULL pointer dereferences.  This
    problem was debugged and fixed by Kevin Hilman
    <khilman@deeprootsystems.com>.
    Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
    Signed-off-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
    Cc: Jouni Högander <jouni.hogander@nokia.com>
    369d5614
pm34xx.c 29.2 KB