• Chuck Lever's avatar
    svcrdma: Ignore source port when computing DRC hash · 3774d334
    Chuck Lever authored
    commit 1e091c3b upstream.
    
    The DRC appears to be effectively empty after an RPC/RDMA transport
    reconnect. The problem is that each connection uses a different
    source port, which defeats the DRC hash.
    
    Clients always have to disconnect before they send retransmissions
    to reset the connection's credit accounting, thus every retransmit
    on NFS/RDMA will miss the DRC.
    
    An NFS/RDMA client's IP source port is meaningless for RDMA
    transports. The transport layer typically sets the source port value
    on the connection to a random ephemeral port. The server already
    ignores it for the "secure port" check. See commit 16e4d93f
    ("NFSD: Ignore client's source port on RDMA transports").
    
    The Linux NFS server's DRC resolves XID collisions from the same
    source IP address by using the checksum of the first 200 bytes of
    the RPC call header.
    Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    Cc: stable@vger.kernel.org # v4.14+
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    3774d334
svc_rdma_transport.c 20.9 KB