• Marc St-Amand's avatar
    net: macb: Align the dma and coherent dma masks · 37f78606
    Marc St-Amand authored
    Single page and coherent memory blocks can use different DMA masks
    when the macb accesses physical memory directly. The kernel is clever
    enough to allocate pages that fit into the requested address width.
    
    When using the ARM SMMU, the DMA mask must be the same for single
    pages and big coherent memory blocks. Otherwise the translation
    tables turn into one big mess.
    
      [   74.959909] macb ff0e0000.ethernet eth0: DMA bus error: HRESP not OK
      [   74.959989] arm-smmu fd800000.smmu: Unhandled context fault: fsr=0x402, iova=0x3165687460, fsynr=0x20001, cbfrsynra=0x877, cb=1
      [   75.173939] macb ff0e0000.ethernet eth0: DMA bus error: HRESP not OK
      [   75.173955] arm-smmu fd800000.smmu: Unhandled context fault: fsr=0x402, iova=0x3165687460, fsynr=0x20001, cbfrsynra=0x877, cb=1
    
    Since using the same DMA mask does not hurt direct 1:1 physical
    memory mappings, this commit always aligns DMA and coherent masks.
    Signed-off-by: default avatarMarc St-Amand <mstamand@ciena.com>
    Signed-off-by: default avatarHarini Katakam <harini.katakam@xilinx.com>
    Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
    Tested-by: default avatarConor Dooley <conor.dooley@microchip.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    37f78606
macb_main.c 129 KB