• Ping-Ke Shih's avatar
    wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS · 3918dd01
    Ping-Ke Shih authored
    This driver relies on IEEE80211_CONF_PS of hw->conf.flags to turn off PS or
    turn on dynamic PS controlled by driver and firmware. Though this would be
    incorrect, it did work before because the flag is always recalculated until
    the commit 28977e79 ("wifi: mac80211: skip powersave recalc if driver SUPPORTS_DYNAMIC_PS")
    is introduced by kernel 5.20 to skip to recalculate IEEE80211_CONF_PS
    of hw->conf.flags if driver sets SUPPORTS_DYNAMIC_PS.
    
    Correct this by doing recalculation while BSS_CHANGED_PS is changed and
    interface is added or removed. It is allowed to enter PS only if single
    one station vif is working. Without this fix, driver doesn't enter PS
    anymore that causes higher power consumption.
    
    Fixes: bcde60e5 ("rtw88: remove misleading module parameter rtw_fw_support_lps")
    Cc: stable@vger.kernel.org # 6.1+
    Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
    Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/20230527082939.11206-2-pkshih@realtek.com
    3918dd01
mac80211.c 23.9 KB