• Matt Roper's avatar
    drm: Make integer overflow checking cover universal cursor updates (v2) · 3968be94
    Matt Roper authored
    Our legacy SetPlane updates perform integer overflow checking on a
    plane's destination rectangle in drm_mode_setplane(), and atomic updates
    handled as part of a drm_atomic_state transaction do the same checking
    in drm_atomic_plane_check().  However legacy cursor updates that get
    routed through universal plane interfaces may bypass this overflow
    checking if the driver's .update_plane is serviced by the transitional
    plane helpers rather than the full atomic plane helpers.
    
    Move the check for destination rectangle integer overflow from the
    drm_mode_setplane() to __setplane_internal() so that it also covers
    cursor operations.
    
    This fixes an issue first noticed with i915 commit:
    
            commit ff42e093
            Author: Daniel Vetter <daniel.vetter@ffwll.ch>
            Date:   Mon Mar 2 16:35:20 2015 +0100
    
                Revert "drm/i915: Switch planes from transitional helpers to full
                atomic helpers"
    
    The above revert switched us from full atomic helpers back to the
    transitional helpers, and in doing so we lost the overflow checking here
    for universal cursor updates.  Even though such extreme cursor positions
    are unlikely to actually happen in the wild, we still don't want there
    to be a change of behavior when drivers switch from transitional helpers
    to full helpers.
    
    v2: Move check from setplane ioctl to setplane_internal rather than
        adding an additional copy of the checks to the transitional plane
        helpers.  (Daniel)
    
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Testcase: igt/kms_cursor_crc
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84269Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    3968be94
drm_crtc.c 152 KB