• Jakub Kicinski's avatar
    tools: ynl: fix duplicate op name in devlink · 39f04b14
    Jakub Kicinski authored
    We don't support CRUD-inspired message types in YNL too well.
    One aspect that currently trips us up is the fact that single
    message ID can be used in multiple commands (as the response).
    This leads to duplicate entries in the id-to-string tables:
    
    devlink-user.c:19:34: warning: initialized field overwritten [-Woverride-init]
       19 |         [DEVLINK_CMD_PORT_NEW] = "port-new",
          |                                  ^~~~~~~~~~
    devlink-user.c:19:34: note: (near initialization for ‘devlink_op_strmap[7]’)
    
    Fixes tag points at where the code was generated, the "real" problem
    is that the code generator does not support CRUD.
    
    Fixes: f2f9dd16 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")
    Link: https://lore.kernel.org/r/20231123030558.1611831-1-kuba@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    39f04b14
ynl-gen-c.py 93.3 KB