• Felix Moessbauer's avatar
    io_uring/sqpoll: do not allow pinning outside of cpuset · f011c9cf
    Felix Moessbauer authored
    The submit queue polling threads are userland threads that just never
    exit to the userland. When creating the thread with IORING_SETUP_SQ_AFF,
    the affinity of the poller thread is set to the cpu specified in
    sq_thread_cpu. However, this CPU can be outside of the cpuset defined
    by the cgroup cpuset controller. This violates the rules defined by the
    cpuset controller and is a potential issue for realtime applications.
    
    In b7ed6d8ffd6 we fixed the default affinity of the poller thread, in
    case no explicit pinning is required by inheriting the one of the
    creating task. In case of explicit pinning, the check is more
    complicated, as also a cpu outside of the parent cpumask is allowed.
    We implemented this by using cpuset_cpus_allowed (that has support for
    cgroup cpusets) and testing if the requested cpu is in the set.
    
    Fixes: 37d1e2e3 ("io_uring: move SQPOLL thread io-wq forked worker")
    Cc: stable@vger.kernel.org # 6.1+
    Signed-off-by: default avatarFelix Moessbauer <felix.moessbauer@siemens.com>
    Link: https://lore.kernel.org/r/20240909150036.55921-1-felix.moessbauer@siemens.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    f011c9cf
sqpoll.c 12.1 KB