• Mark Brown's avatar
    Merge series "Add support for Kontron sl28cpld" from Michael Walle <michael@walle.cc>: · 3ada1b17
    Mark Brown authored
    The Kontron sl28cpld is a board management chip providing gpio, pwm, fan
    monitoring and an interrupt controller. For now this controller is used on
    the Kontron SMARC-sAL28 board. But because of its flexible nature, it
    might also be used on other boards in the future. The individual blocks
    (like gpio, pwm, etc) are kept intentionally small. The MFD core driver
    then instantiates different (or multiple of the same) blocks. It also
    provides the register layout so it might be updated in the future without a
    device tree change; and support other boards with a different layout or
    functionalities.
    
    See also [1] for more information.
    
    This is my first take of a MFD driver. I don't know whether the subsystem
    maintainers should only be CCed on the patches which affect the subsystem
    or on all patches for this series. I've chosen the latter so you can get a
    more complete picture.
    
    [1] https://lore.kernel.org/linux-devicetree/0e3e8204ab992d75aa07fc36af7e4ab2@walle.cc/
    
    Changes since v1:
     - use of_match_table in all drivers, needed for automatic module loading,
       when using OF_MFD_CELL()
     - add new gpio-regmap.c which adds a generic regmap gpio_chip implemention
     - new patch for reqmap_irq, so we can reuse its implementation
     - remove almost any code from gpio-sl28cpld.c, instead use gpio-regmap and
       regmap-irq
     - change the handling of the mfd core vs device tree nodes; add a new
       property "of_reg" to the mfd_cell struct which, when set, is matched to
       the unit-address of the device tree nodes.
     - fix sl28cpld watchdog when it is not initialized by the bootloader.
       Explicitly set the operation mode.
     - also add support for kontron,assert-wdt-timeout-pin in sl28cpld-wdt.
    
    As suggested by Bartosz Golaszewski:
     - define registers as hex
     - make gpio enum uppercase
     - move parent regmap check before memory allocation
     - use device_property_read_bool() instead of the of_ version
     - mention the gpio flavors in the bindings documentation
    
    As suggested by Guenter Roeck:
     - cleanup #includes and sort them
     - use devm_watchdog_register_device()
     - use watchdog_stop_on_reboot()
     - provide a Documentation/hwmon/sl28cpld.rst
     - cleaned up the weird tristate->bool and I2C=y issue. Instead mention
       that the MFD driver is bool because of the following intc patch
     - removed the SL28CPLD_IRQ typo
    
    As suggested by Rob Herring:
     - combine all dt bindings docs into one patch
     - change the node name for all gpio flavors to "gpio"
     - removed the interrupts-extended rule
     - cleaned up the unit-address space, see above
    
    Michael Walle (16):
      include/linux/ioport.h: add helper to define REG resource constructs
      mfd: mfd-core: Don't overwrite the dma_mask of the child device
      mfd: mfd-core: match device tree node against reg property
      regmap-irq: make it possible to add irq_chip do a specific device node
      dt-bindings: mfd: Add bindings for sl28cpld
      mfd: Add support for Kontron sl28cpld management controller
      irqchip: add sl28cpld interrupt controller support
      watchdog: add support for sl28cpld watchdog
      pwm: add support for sl28cpld PWM controller
      gpio: add a reusable generic gpio_chip using regmap
      gpio: add support for the sl28cpld GPIO controller
      hwmon: add support for the sl28cpld hardware monitoring controller
      arm64: dts: freescale: sl28: enable sl28cpld
      arm64: dts: freescale: sl28: map GPIOs to input events
      arm64: dts: freescale: sl28: enable LED support
      arm64: dts: freescale: sl28: enable fan support
    
     .../bindings/gpio/kontron,sl28cpld-gpio.yaml  |  51 +++
     .../hwmon/kontron,sl28cpld-hwmon.yaml         |  27 ++
     .../bindings/mfd/kontron,sl28cpld.yaml        | 162 +++++++++
     .../bindings/pwm/kontron,sl28cpld-pwm.yaml    |  35 ++
     .../watchdog/kontron,sl28cpld-wdt.yaml        |  35 ++
     Documentation/hwmon/sl28cpld.rst              |  36 ++
     .../fsl-ls1028a-kontron-kbox-a-230-ls.dts     |  14 +
     .../fsl-ls1028a-kontron-sl28-var3-ads2.dts    |   9 +
     .../freescale/fsl-ls1028a-kontron-sl28.dts    | 124 +++++++
     drivers/base/regmap/regmap-irq.c              |  84 ++++-
     drivers/gpio/Kconfig                          |  15 +
     drivers/gpio/Makefile                         |   2 +
     drivers/gpio/gpio-regmap.c                    | 321 ++++++++++++++++++
     drivers/gpio/gpio-sl28cpld.c                  | 187 ++++++++++
     drivers/hwmon/Kconfig                         |  10 +
     drivers/hwmon/Makefile                        |   1 +
     drivers/hwmon/sl28cpld-hwmon.c                | 152 +++++++++
     drivers/irqchip/Kconfig                       |   3 +
     drivers/irqchip/Makefile                      |   1 +
     drivers/irqchip/irq-sl28cpld.c                |  99 ++++++
     drivers/mfd/Kconfig                           |  21 ++
     drivers/mfd/Makefile                          |   2 +
     drivers/mfd/mfd-core.c                        |  31 +-
     drivers/mfd/sl28cpld.c                        | 154 +++++++++
     drivers/pwm/Kconfig                           |  10 +
     drivers/pwm/Makefile                          |   1 +
     drivers/pwm/pwm-sl28cpld.c                    | 204 +++++++++++
     drivers/watchdog/Kconfig                      |  11 +
     drivers/watchdog/Makefile                     |   1 +
     drivers/watchdog/sl28cpld_wdt.c               | 242 +++++++++++++
     include/linux/gpio-regmap.h                   |  88 +++++
     include/linux/ioport.h                        |   5 +
     include/linux/mfd/core.h                      |  26 +-
     include/linux/regmap.h                        |  10 +
     34 files changed, 2142 insertions(+), 32 deletions(-)
     create mode 100644 Documentation/devicetree/bindings/gpio/kontron,sl28cpld-gpio.yaml
     create mode 100644 Documentation/devicetree/bindings/hwmon/kontron,sl28cpld-hwmon.yaml
     create mode 100644 Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml
     create mode 100644 Documentation/devicetree/bindings/pwm/kontron,sl28cpld-pwm.yaml
     create mode 100644 Documentation/devicetree/bindings/watchdog/kontron,sl28cpld-wdt.yaml
     create mode 100644 Documentation/hwmon/sl28cpld.rst
     create mode 100644 drivers/gpio/gpio-regmap.c
     create mode 100644 drivers/gpio/gpio-sl28cpld.c
     create mode 100644 drivers/hwmon/sl28cpld-hwmon.c
     create mode 100644 drivers/irqchip/irq-sl28cpld.c
     create mode 100644 drivers/mfd/sl28cpld.c
     create mode 100644 drivers/pwm/pwm-sl28cpld.c
     create mode 100644 drivers/watchdog/sl28cpld_wdt.c
     create mode 100644 include/linux/gpio-regmap.h
    
    --
    2.20.1
    
    _______________________________________________
    linux-arm-kernel mailing list
    linux-arm-kernel@lists.infradead.org
    http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
    3ada1b17
regmap.h 53.4 KB