• Bart Van Assche's avatar
    scsi: ufs: core: mcq: Fix ufshcd_mcq_sqe_search() · 3c5d0dce
    Bart Van Assche authored
    Fix the calculation of the utrd pointer. This patch addresses the following
    Coverity complaint:
    
    CID 1538170: (#1 of 1): Extra sizeof expression (SIZEOF_MISMATCH)
    suspicious_pointer_arithmetic: Adding sq_head_slot * 32UL /* sizeof (struct
    utp_transfer_req_desc) */ to pointer hwq->sqe_base_addr of type struct
    utp_transfer_req_desc * is suspicious because adding an integral value to
    this pointer automatically scales that value by the size, 32 bytes, of the
    pointed-to type, struct utp_transfer_req_desc. Most likely, the
    multiplication by sizeof (struct utp_transfer_req_desc) in this expression
    is extraneous and should be eliminated.
    
    Cc: Bao D. Nguyen <quic_nguyenb@quicinc.com>
    Cc: Stanley Chu <stanley.chu@mediatek.com>
    Cc: Can Guo <quic_cang@quicinc.com>
    Fixes: 8d729034 ("scsi: ufs: mcq: Add supporting functions for MCQ abort")
    Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
    Link: https://lore.kernel.org/r/20240410000751.1047758-1-bvanassche@acm.orgSigned-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    3c5d0dce
ufs-mcq.c 18.5 KB