• Masami Hiramatsu (Google)'s avatar
    tracing: fprobe-event: Fix to check tracepoint event and return · ce51e615
    Masami Hiramatsu (Google) authored
    Fix to check the tracepoint event is not valid with $retval.
    The commit 08c9306f ("tracing/fprobe-event: Assume fprobe is
    a return event by $retval") introduced automatic return probe
    conversion with $retval. But since tracepoint event does not
    support return probe, $retval is not acceptable.
    
    Without this fix, ftracetest, tprobe_syntax_errors.tc fails;
    
    [22] Tracepoint probe event parser error log check      [FAIL]
     ----
     # tail 22-tprobe_syntax_errors.tc-log.mRKroL
     + ftrace_errlog_check trace_fprobe t kfree ^$retval dynamic_events
     + printf %s t kfree
     + wc -c
     + pos=8
     + printf %s t kfree ^$retval
     + tr -d ^
     + command=t kfree $retval
     + echo Test command: t kfree $retval
     Test command: t kfree $retval
     + echo
     ----
    
    So 't kfree $retval' should fail (tracepoint doesn't support
    return probe) but passed it.
    
    Link: https://lore.kernel.org/all/169944555933.45057.12831706585287704173.stgit@devnote2/
    
    Fixes: 08c9306f ("tracing/fprobe-event: Assume fprobe is a return event by $retval")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
    ce51e615
trace_fprobe.c 29.7 KB