• Vivek Goyal's avatar
    virtiofs: calculate number of scatter-gather elements accurately · 42d3e2d0
    Vivek Goyal authored
    virtiofs currently maps various buffers in scatter gather list and it looks
    at number of pages (ap->pages) and assumes that same number of pages will
    be used both for input and output (sg_count_fuse_req()), and calculates
    total number of scatterlist elements accordingly.
    
    But looks like this assumption is not valid in all the cases. For example,
    Cai Qian reported that trinity, triggers warning with virtiofs sometimes.
    A closer look revealed that if one calls ioctl(fd, 0x5a004000, buf), it
    will trigger following warning.
    
    WARN_ON(out_sgs + in_sgs != total_sgs)
    
    In this case, total_sgs = 8, out_sgs=4, in_sgs=3. Number of pages is 2
    (ap->pages), but out_sgs are using both the pages but in_sgs are using
    only one page. In this case, fuse_do_ioctl() sets different size values
    for input and output.
    
    args->in_args[args->in_numargs - 1].size == 6656
    args->out_args[args->out_numargs - 1].size == 4096
    
    So current method of calculating how many scatter-gather list elements
    will be used is not accurate. Make calculations more precise by parsing
    size and ap->descs.
    Reported-by: default avatarQian Cai <cai@redhat.com>
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Link: https://lore.kernel.org/linux-fsdevel/5ea77e9f6cb8c2db43b09fbd4158ab2d8c066a0a.camel@redhat.com/Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    42d3e2d0
virtio_fs.c 36.8 KB