Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • drivers
  • gpu
  • drm
  • drm_debugfs.c
Find file BlameHistoryPermalink
  • Derek Foreman's avatar
    drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes · f0fa69b5
    Derek Foreman authored Aug 27, 2024
    The largest infoframe we create is the DRM (Dynamic Range Mastering)
    infoframe which is 26 bytes + a 4 byte header, for a total of 30
    bytes.
    
    With HDMI_MAX_INFOFRAME_SIZE set to 29 bytes, as it is now, we
    allocate too little space to pack a DRM infoframe in
    write_device_infoframe(), leading to an ENOSPC return from
    hdmi_infoframe_pack(), and never calling the connector's
    write_infoframe() vfunc.
    
    Instead of having HDMI_MAX_INFOFRAME_SIZE defined in two places,
    replace HDMI_MAX_INFOFRAME_SIZE with HDMI_INFOFRAME_SIZE(MAX) and make
    MAX 27 bytes - which is defined by the HDMI specification to be the
    largest infoframe payload.
    
    Fixes: f378b772 ("drm/connector: hdmi: Add Infoframes generation")
    Fixes: c602e495
    
     ("drm/connector: hdmi: Create Infoframe DebugFS entries")
    
    Signed-off-by: default avatarDerek Foreman <derek.foreman@collabora.com>
    Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
    Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20240827163918.48160-1-derek.foreman@collabora.com
    
    
    Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
    f0fa69b5
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7