• Namhyung Kim's avatar
    perf bpf filter: Show warning for missing sample flags · 4310551b
    Namhyung Kim authored
    For a BPF filter to work properly, users need to provide appropriate
    options to enable the sample types.  Otherwise the BPF program would
    see an invalid value (i.e. always 0) and filter won't work well.
    
    Show a warning message if sample types are missing like below.
    
      $ sudo ./perf record -e cycles --filter 'addr < 100' true
      Error: cycles event does not have PERF_SAMPLE_ADDR
       Hint: please add -d option to perf record.
      failed to set filter "BPF" on event cycles with 22 (Invalid argument)
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Hao Luo <haoluo@google.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Song Liu <song@kernel.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: bpf@vger.kernel.org
    Link: https://lore.kernel.org/r/20230314234237.3008956-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    4310551b
builtin-record.c 113 KB