• Linus Torvalds's avatar
    minmax: add a few more MIN_T/MAX_T users · 4477b39c
    Linus Torvalds authored
    Commit 3a7e02c0 ("minmax: avoid overly complicated constant
    expressions in VM code") added the simpler MIN_T/MAX_T macros in order
    to avoid some excessive expansion from the rather complicated regular
    min/max macros.
    
    The complexity of those macros stems from two issues:
    
     (a) trying to use them in situations that require a C constant
         expression (in static initializers and for array sizes)
    
     (b) the type sanity checking
    
    and MIN_T/MAX_T avoids both of these issues.
    
    Now, in the whole (long) discussion about all this, it was pointed out
    that the whole type sanity checking is entirely unnecessary for
    min_t/max_t which get a fixed type that the comparison is done in.
    
    But that still leaves min_t/max_t unnecessarily complicated due to
    worries about the C constant expression case.
    
    However, it turns out that there really aren't very many cases that use
    min_t/max_t for this, and we can just force-convert those.
    
    This does exactly that.
    
    Which in turn will then allow for much simpler implementations of
    min_t()/max_t().  All the usual "macros in all upper case will evaluate
    the arguments multiple times" rules apply.
    
    We should do all the same things for the regular min/max() vs MIN/MAX()
    cases, but that has the added complexity of various drivers defining
    their own local versions of MIN/MAX, so that needs another level of
    fixes first.
    
    Link: https://lore.kernel.org/all/b47fad1d0cf8449886ad148f8c013dae@AcuMS.aculab.com/
    Cc: David Laight <David.Laight@aculab.com>
    Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    4477b39c
stmmac_main.c 220 KB