• Pavel Skripkin's avatar
    media: mxl111sf: change mutex_init() location · 44870a9e
    Pavel Skripkin authored
    Syzbot reported, that mxl111sf_ctrl_msg() uses uninitialized
    mutex. The problem was in wrong mutex_init() location.
    
    Previous mutex_init(&state->msg_lock) call was in ->init() function, but
    dvb_usbv2_init() has this order of calls:
    
    	dvb_usbv2_init()
    	  dvb_usbv2_adapter_init()
    	    dvb_usbv2_adapter_frontend_init()
    	      props->frontend_attach()
    
    	  props->init()
    
    Since mxl111sf_* devices call mxl111sf_ctrl_msg() in ->frontend_attach()
    internally we need to initialize state->msg_lock before
    frontend_attach(). To achieve it, ->probe() call added to all mxl111sf_*
    devices, which will simply initiaize mutex.
    
    Reported-and-tested-by: syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com
    
    Fixes: 85722118 ("[media] mxl111sf: convert to new DVB USB")
    Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: default avatarSean Young <sean@mess.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    44870a9e
mxl111sf.c 40.3 KB