• Jinjie Ruan's avatar
    mm/damon/vaddr-test: fix memory leak in damon_do_test_apply_three_regions() · 45120b15
    Jinjie Ruan authored
    When CONFIG_DAMON_VADDR_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y
    and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected.
    
    Since commit 9f86d624 ("mm/damon/vaddr-test: remove unnecessary
    variables"), the damon_destroy_ctx() is removed, but still call
    damon_new_target() and damon_new_region(), the damon_region which is
    allocated by kmem_cache_alloc() in damon_new_region() and the damon_target
    which is allocated by kmalloc in damon_new_target() are not freed.  And
    the damon_region which is allocated in damon_new_region() in
    damon_set_regions() is also not freed.
    
    So use damon_destroy_target to free all the damon_regions and damon_target.
    
        unreferenced object 0xffff888107c9a940 (size 64):
          comm "kunit_try_catch", pid 1069, jiffies 4294670592 (age 732.761s)
          hex dump (first 32 bytes):
            00 00 00 00 00 00 00 00 06 00 00 00 6b 6b 6b 6b  ............kkkk
            60 c7 9c 07 81 88 ff ff f8 cb 9c 07 81 88 ff ff  `...............
          backtrace:
            [<ffffffff817e0167>] kmalloc_trace+0x27/0xa0
            [<ffffffff819c11cf>] damon_new_target+0x3f/0x1b0
            [<ffffffff819c7d55>] damon_do_test_apply_three_regions.constprop.0+0x95/0x3e0
            [<ffffffff819c82be>] damon_test_apply_three_regions1+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff8881079cc740 (size 56):
          comm "kunit_try_catch", pid 1069, jiffies 4294670592 (age 732.761s)
          hex dump (first 32 bytes):
            05 00 00 00 00 00 00 00 14 00 00 00 00 00 00 00  ................
            6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b  kkkkkkkk....kkkk
          backtrace:
            [<ffffffff819bc492>] damon_new_region+0x22/0x1c0
            [<ffffffff819c7d91>] damon_do_test_apply_three_regions.constprop.0+0xd1/0x3e0
            [<ffffffff819c82be>] damon_test_apply_three_regions1+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff888107c9ac40 (size 64):
          comm "kunit_try_catch", pid 1071, jiffies 4294670595 (age 732.843s)
          hex dump (first 32 bytes):
            00 00 00 00 00 00 00 00 06 00 00 00 6b 6b 6b 6b  ............kkkk
            a0 cc 9c 07 81 88 ff ff 78 a1 76 07 81 88 ff ff  ........x.v.....
          backtrace:
            [<ffffffff817e0167>] kmalloc_trace+0x27/0xa0
            [<ffffffff819c11cf>] damon_new_target+0x3f/0x1b0
            [<ffffffff819c7d55>] damon_do_test_apply_three_regions.constprop.0+0x95/0x3e0
            [<ffffffff819c851e>] damon_test_apply_three_regions2+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff8881079ccc80 (size 56):
          comm "kunit_try_catch", pid 1071, jiffies 4294670595 (age 732.843s)
          hex dump (first 32 bytes):
            05 00 00 00 00 00 00 00 14 00 00 00 00 00 00 00  ................
            6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b  kkkkkkkk....kkkk
          backtrace:
            [<ffffffff819bc492>] damon_new_region+0x22/0x1c0
            [<ffffffff819c7d91>] damon_do_test_apply_three_regions.constprop.0+0xd1/0x3e0
            [<ffffffff819c851e>] damon_test_apply_three_regions2+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff888107c9af40 (size 64):
          comm "kunit_try_catch", pid 1073, jiffies 4294670597 (age 733.011s)
          hex dump (first 32 bytes):
            00 00 00 00 00 00 00 00 06 00 00 00 6b 6b 6b 6b  ............kkkk
            20 a2 76 07 81 88 ff ff b8 a6 76 07 81 88 ff ff   .v.......v.....
          backtrace:
            [<ffffffff817e0167>] kmalloc_trace+0x27/0xa0
            [<ffffffff819c11cf>] damon_new_target+0x3f/0x1b0
            [<ffffffff819c7d55>] damon_do_test_apply_three_regions.constprop.0+0x95/0x3e0
            [<ffffffff819c877e>] damon_test_apply_three_regions3+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff88810776a200 (size 56):
          comm "kunit_try_catch", pid 1073, jiffies 4294670597 (age 733.011s)
          hex dump (first 32 bytes):
            05 00 00 00 00 00 00 00 14 00 00 00 00 00 00 00  ................
            6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b  kkkkkkkk....kkkk
          backtrace:
            [<ffffffff819bc492>] damon_new_region+0x22/0x1c0
            [<ffffffff819c7d91>] damon_do_test_apply_three_regions.constprop.0+0xd1/0x3e0
            [<ffffffff819c877e>] damon_test_apply_three_regions3+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff88810776a740 (size 56):
          comm "kunit_try_catch", pid 1073, jiffies 4294670597 (age 733.025s)
          hex dump (first 32 bytes):
            3d 00 00 00 00 00 00 00 3f 00 00 00 00 00 00 00  =.......?.......
            6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b  kkkkkkkk....kkkk
          backtrace:
            [<ffffffff819bc492>] damon_new_region+0x22/0x1c0
            [<ffffffff819bfcc2>] damon_set_regions+0x4c2/0x8e0
            [<ffffffff819c7dbb>] damon_do_test_apply_three_regions.constprop.0+0xfb/0x3e0
            [<ffffffff819c877e>] damon_test_apply_three_regions3+0x21e/0x260
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff888108038240 (size 64):
          comm "kunit_try_catch", pid 1075, jiffies 4294670600 (age 733.022s)
          hex dump (first 32 bytes):
            00 00 00 00 00 00 00 00 03 00 00 00 6b 6b 6b 6b  ............kkkk
            48 ad 76 07 81 88 ff ff 98 ae 76 07 81 88 ff ff  H.v.......v.....
          backtrace:
            [<ffffffff817e0167>] kmalloc_trace+0x27/0xa0
            [<ffffffff819c11cf>] damon_new_target+0x3f/0x1b0
            [<ffffffff819c7d55>] damon_do_test_apply_three_regions.constprop.0+0x95/0x3e0
            [<ffffffff819c898d>] damon_test_apply_three_regions4+0x1cd/0x210
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
        unreferenced object 0xffff88810776ad28 (size 56):
          comm "kunit_try_catch", pid 1075, jiffies 4294670600 (age 733.022s)
          hex dump (first 32 bytes):
            05 00 00 00 00 00 00 00 07 00 00 00 00 00 00 00  ................
            6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b  kkkkkkkk....kkkk
          backtrace:
            [<ffffffff819bc492>] damon_new_region+0x22/0x1c0
            [<ffffffff819bfcc2>] damon_set_regions+0x4c2/0x8e0
            [<ffffffff819c7dbb>] damon_do_test_apply_three_regions.constprop.0+0xfb/0x3e0
            [<ffffffff819c898d>] damon_test_apply_three_regions4+0x1cd/0x210
            [<ffffffff829fce6a>] kunit_generic_run_threadfn_adapter+0x4a/0x90
            [<ffffffff81237cf6>] kthread+0x2b6/0x380
            [<ffffffff81097add>] ret_from_fork+0x2d/0x70
            [<ffffffff81003791>] ret_from_fork_asm+0x11/0x20
    
    Link: https://lkml.kernel.org/r/20230925072100.3725620-1-ruanjinjie@huawei.com
    Fixes: 9f86d624 ("mm/damon/vaddr-test: remove unnecessary variables")
    Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
    Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    45120b15
vaddr-test.h 11 KB