• Mike Baynton's avatar
    ovl: fail if trusted xattrs are needed but caller lacks permission · 6c4a5f96
    Mike Baynton authored
    Some overlayfs features require permission to read/write trusted.*
    xattrs. These include redirect_dir, verity, metacopy, and data-only
    layers. This patch adds additional validations at mount time to stop
    overlays from mounting in certain cases where the resulting mount would
    not function according to the user's expectations because they lack
    permission to access trusted.* xattrs (for example, not global root.)
    
    Similar checks in ovl_make_workdir() that disable features instead of
    failing are still relevant and used in cases where the resulting mount
    can still work "reasonably well." Generally, if the feature was enabled
    through kernel config or module option, any mount that worked before
    will still work the same; this applies to redirect_dir and metacopy. The
    user must explicitly request these features in order to generate a mount
    failure. Verity and data-only layers on the other hand must be explictly
    requested and have no "reasonable" disabled or degraded alternative, so
    mounts attempting either always fail.
    
    "lower data-only dirs require metacopy support" moved down in case
    userxattr is set, which disables metacopy.
    
    Cc: stable@vger.kernel.org # v6.6+
    Signed-off-by: default avatarMike Baynton <mike@mbaynton.com>
    Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
    6c4a5f96
params.c 25.6 KB