• Linus Torvalds's avatar
    ALSA: fix hda AZX_DCAPS_NO_TCSEL quirk check in driver_caps · 46f2cc80
    Linus Torvalds authored
    Commit 9477c58e ("ALSA: hda - Reorganize controller quriks with bit
    flags") changed the driver type compares into various quirk bits.
    However, the check for AZX_DCAPS_NO_TCSEL got reverted: instead of
    clearing TCSEL for chipsets that have that standard capability, it
    cleared then when the NO_TCSEL bit was set.
    
    This can lead to noise and repeated sounds - a weird "echo" behavior.
    As the comment just above says: "Ensuring these bits are 0 clears
    playback static on some HD Audio codecs".  Which is definitely true at
    least on my Core i5 Westmere system.
    
    Cc: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    46f2cc80
hda_intel.c 78.9 KB