• Arnd Bergmann's avatar
    usb: gadget: pxa25x_udc: use readl/writel for mmio · 65bc0fba
    Arnd Bergmann authored
    This converts the pxa25x udc driver to use readl/writel as normal
    driver should do, rather than dereferencing __iomem pointers
    themselves.
    
    Based on the earlier preparation work, we can now also pass
    the register start in the device pointer so we no longer need
    the global variable.
    
    The unclear part here is for IXP4xx, which supports both big-endian
    and little-endian configurations. So far, the driver has done
    no byteswap in either case. I suspect that is wrong and it would
    actually need to swap in one or the other case, but I don't know
    which. It's also possible that there is some magic setting in
    the chip that makes the endianess of the MMIO register match the
    CPU, and in that case, the code actually does the right thing
    for all configurations, both before and after this patch.
    Acked-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
    65bc0fba
pxa25x_udc.h 6.52 KB