• Linus Torvalds's avatar
    Revert "vfs: Delete the associated dentry when deleting a file" · 4a4be1ad
    Linus Torvalds authored
    This reverts commit 681ce862.
    
    We gave it a try, but it turns out the kernel test robot did in fact
    find performance regressions for it, so we'll have to look at the more
    involved alternative fixes for Yafang Shao's Elasticsearch load issue.
    
    There were several alternatives discussed, they just weren't as simple
    as this first attempt.
    
    The report is of a -7.4% regression of filebench.sum_operations/s, which
    appears significant enough to trigger my "this patch may get reverted if
    somebody finds a performance regression on some other load" rule.
    
    So it's still the case that we should end up deleting dentries more
    aggressively - or just be better at pruning them later - but it needs a
    bit more finesse than this simple thing.
    
    Link: https://lore.kernel.org/all/202405291318.4dfbb352-oliver.sang@intel.com/
    Cc: Yafang Shao <laoar.shao@gmail.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Christian Brauner <brauner@kernel.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    4a4be1ad
dcache.c 83.6 KB