• Hugh Dickins's avatar
    mm/migrate_device: allow pte_offset_map_lock() to fail · 4b56069c
    Hugh Dickins authored
    migrate_vma_collect_pmd(): remove the pmd_trans_unstable() handling after
    splitting huge zero pmd, and the pmd_none() handling after successfully
    splitting huge page: those are now managed inside pte_offset_map_lock(),
    and by "goto again" when it fails.
    
    But the skip after unsuccessful split_huge_page() must stay: it avoids an
    endless loop.  The skip when pmd_bad()?  Remove that: it will be treated
    as a hole rather than a skip once cleared by pte_offset_map_lock(), but
    with different timing that would be so anyway; and it's arguably best to
    leave the pmd_bad() handling centralized there.
    
    migrate_vma_insert_page(): remove comment on the old pte_offset_map() and
    old locking limitations; remove the pmd_trans_unstable() check and just
    proceed to pte_offset_map_lock(), aborting when it fails (page has been
    charged to memcg, but as in other cases, it's uncharged when freed).
    
    Link: https://lkml.kernel.org/r/1131be62-2e84-da2f-8f45-807b2cbeeec5@google.comSigned-off-by: default avatarHugh Dickins <hughd@google.com>
    Reviewed-by: default avatarAlistair Popple <apopple@nvidia.com>
    Cc: Anshuman Khandual <anshuman.khandual@arm.com>
    Cc: Axel Rasmussen <axelrasmussen@google.com>
    Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
    Cc: Christoph Hellwig <hch@infradead.org>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: "Huang, Ying" <ying.huang@intel.com>
    Cc: Ira Weiny <ira.weiny@intel.com>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Lorenzo Stoakes <lstoakes@gmail.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Mel Gorman <mgorman@techsingularity.net>
    Cc: Miaohe Lin <linmiaohe@huawei.com>
    Cc: Mike Kravetz <mike.kravetz@oracle.com>
    Cc: Mike Rapoport (IBM) <rppt@kernel.org>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
    Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
    Cc: Peter Xu <peterx@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Qi Zheng <zhengqi.arch@bytedance.com>
    Cc: Ralph Campbell <rcampbell@nvidia.com>
    Cc: Ryan Roberts <ryan.roberts@arm.com>
    Cc: SeongJae Park <sj@kernel.org>
    Cc: Song Liu <song@kernel.org>
    Cc: Steven Price <steven.price@arm.com>
    Cc: Suren Baghdasaryan <surenb@google.com>
    Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Cc: Will Deacon <will@kernel.org>
    Cc: Yang Shi <shy828301@gmail.com>
    Cc: Yu Zhao <yuzhao@google.com>
    Cc: Zack Rusin <zackr@vmware.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    4b56069c
migrate_device.c 26.7 KB