• Chris Wilson's avatar
    drm/i915: Drop the overzealous warning from i915_gem_set_cache_level · 4b6d846e
    Chris Wilson authored
    By our earlier reckoning, move from a snooped/llc setting to an uncached
    setting, leaves the CPU cache in a consistent state irrespective of our
    domain tracking - so we can forgo the warning about the lack of
    invalidation. Similarly for any writes posted to the snooped CPU domain,
    we know will be safely clflushed to the uncached PTEs after forcing the
    domain change.
    
    This WARN started to pop up with
    
    commit d46f1c3f
    Author:     Chris Wilson <chris@chris-wilson.co.uk>
    AuthorDate: Thu Aug 8 14:41:06 2013 +0100
    
        drm/i915: Allow the GPU to cache stolen memory
    
    Ville brought up a scenario where the interaction of a set_caching
    ioctl call from userspace on a scanout buffer (i.e. obj->pin_display
    is set) resulted in the code getting confused and not properly
    flushing stale cpu cachelines. Luckily we already prevent this by
    rejecting caching changes when obj->pin_count is set.
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68040Tested-by: default avatarcancan,feng <cancan.feng@intel.com>
    [danvet: Add buglink, bisect result and explain why Ville's scenario
    is already taken care of.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    4b6d846e
i915_gem.c 122 KB