• Patrick Mansfield's avatar
    [PATCH] Re: 2.6.1-rc1: SCSI: `TIMEOUT' redefined · 7f3999c8
    Patrick Mansfield authored
    On Tue, Jan 06, 2004 at 07:33:25PM +0100, Adrian Bunk wrote:
    > On Wed, Dec 31, 2003 at 12:36:49AM -0800, Linus Torvalds wrote:
    > >...
    > > Summary of changes from v2.6.0 to v2.6.1-rc1
    > > ============================================
    > >...
    > > Patrick Mansfield:
    > >   o consolidate and log scsi command on send and completion
    > >...
    >
    > This adds a #define TIMEOUT to scsi.h conflicting with a different
    > TIMEOUT #define in drivers/scsi/eata_generic.h:
    
    Sorry Adrian, here is a patch renaming TIMEOUT to TIMEOUT_ERROR.  Still
    not a good name for the usage in SCSI core, but it does not conflict, and
    matches the other names for the IO completion results (SUCCESS, FAILED,
    etc., they and others should really be prefixed with at least SCSI).
    
    eata does not use the TIMEOUT it defines, but there are enough defines of
    TIMEOUT that it could be a problem in other drivers.
    
    Only compile tested for eata driver.
    7f3999c8
scsi.h 9.97 KB