• Wolfram Sang's avatar
    ide/ide-cs: fix order of releasing resources · d4ae5415
    Wolfram Sang authored
    ide_detach() called first ide_release() and then release_region(). This
    produced the following warnings:
    
      Trying to free nonexistent resource <000000000000c10e-000000000000c10e>
      Trying to free nonexistent resource <000000000000c100-000000000000c107>
    
    This is true, because the callchain inside ide_release() is:
    
      ide_release -> pcmcia_disable_device -> pcmcia_release_io
    
    So, the whole io-block is already gone for release_region(). To fix
    this, just swap the order of releasing (and remove the now obsolete
    shadowing).
    
    bzolnier:
    - release resources in ide_release() to fix ordering of events
    - remove stale FIXME note while at it
    Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d4ae5415
ide-cs.c 15.3 KB