• Roland Dreier's avatar
    ACPI: Always return valid 'status' from acpi_battery_get_property() · 4c41d3ad
    Roland Dreier authored
    If a battery is at a critical charge level and not being charged or
    discharged, then the ACPI _BST method will return a state of 4, and
    the current acpi_battery_get_property() code will not set any property
    value for POWER_SUPPLY_PROP_STATUS.  This will cause an oops in
    power_supply_show_property() when it reads off the end of the
    status_text array.  This actually was causing a 100% reproducible
    crash on boot on my laptop with two batteries, when one battery was
    completely drained and the laptop was not plugged in.
    
    Fix this by making sure acpi_battery_get_property() returns
    POWER_SUPPLY_STATUS_UNKNOWN for any battery state it doesn't already
    handle explicitly.  There doesn't seem to be any status enum value
    defined that makes more sense than 'unknown' for a battery at a
    critical charge level.
    Signed-off-by: default avatarRoland Dreier <roland@digitalvampire.org>
    Acked-by: default avatarAlexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: default avatarLen Brown <lenb@t61.(none)>
    4c41d3ad
battery.c 24.6 KB