• Alex Elder's avatar
    libceph: collapse all data items into one · 4c59b4a2
    Alex Elder authored
    It turns out that only one of the data item types is ever used at
    any one time in a single message (currently).
        - A page array is used by the osd client (on behalf of the file
          system) and by rbd.  Only one osd op (and therefore at most
          one data item) is ever used at a time by rbd.  And the only
          time the file system sends two, the second op contains no
          data.
        - A bio is only used by the rbd client (and again, only one
          data item per message)
        - A page list is used by the file system and by rbd for outgoing
          data, but only one op (and one data item) at a time.
    
    We can therefore collapse all three of our data item fields into a
    single field "data", and depend on the messenger code to properly
    handle it based on its type.
    
    This allows us to eliminate quite a bit of duplicated code.
    
    This is related to:
        http://tracker.ceph.com/issues/4429Signed-off-by: default avatarAlex Elder <elder@inktank.com>
    Reviewed-by: default avatarJosh Durgin <josh.durgin@inktank.com>
    4c59b4a2
messenger.c 80 KB