• Roman Gushchin's avatar
    mm: slab: make page_cgroup_ino() to recognize non-compound slab pages properly · 221ec5c0
    Roman Gushchin authored
    page_cgroup_ino() doesn't return a valid memcg pointer for non-compound
    slab pages, because it depends on PgHead AND PgSlab flags to be set to
    determine the memory cgroup from the kmem_cache.  It's correct for
    compound pages, but not for generic small pages.  Those don't have PgHead
    set, so it ends up returning zero.
    
    Fix this by replacing the condition to PageSlab() && !PageTail().
    
    Before this patch:
      [root@localhost ~]# ./page-types -c /sys/fs/cgroup/user.slice/user-0.slice/user@0.service/ | grep slab
      0x0000000000000080	        38        0  _______S___________________________________	slab
    
    After this patch:
      [root@localhost ~]# ./page-types -c /sys/fs/cgroup/user.slice/user-0.slice/user@0.service/ | grep slab
      0x0000000000000080	       147        0  _______S___________________________________	slab
    
    Also, hwpoison_filter_task() uses output of page_cgroup_ino() in order
    to filter error injection events based on memcg.  So if
    page_cgroup_ino() fails to return memcg pointer, we just fail to inject
    memory error.  Considering that hwpoison filter is for testing, affected
    users are limited and the impact should be marginal.
    
    [n-horiguchi@ah.jp.nec.com: changelog additions]
    Link: http://lkml.kernel.org/r/20191031012151.2722280-1-guro@fb.com
    Fixes: 4d96ba35 ("mm: memcg/slab: stop setting page->mem_cgroup pointer for slab pages")
    Signed-off-by: default avatarRoman Gushchin <guro@fb.com>
    Reviewed-by: default avatarShakeel Butt <shakeelb@google.com>
    Acked-by: default avatarDavid Rientjes <rientjes@google.com>
    Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
    Cc: Daniel Jordan <daniel.m.jordan@oracle.com>
    Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    221ec5c0
slab.h 19.2 KB